Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PSA compliance fixes #2091

Merged
merged 6 commits into from
Nov 30, 2022
Merged

fix: PSA compliance fixes #2091

merged 6 commits into from
Nov 30, 2022

Conversation

flea89
Copy link
Contributor

@flea89 flea89 commented Nov 2, 2022 •
edited
Loading

resolves #1579

What fixes are part of this PR:

  • Make sure the API responses match the spec ( specifically we were sending some properties that were not allowed) See here
  • Made status not required, and default to "pinned" when no other filter is provided**.
  • Update tests to catch similar issues in the future and some minor polishing

Notes

Not fixed as part of this PR

  • ** I've created a ticket in the compliance tool to discuss how the status query param should behave, since it is slightly confusing at the moment. You can find more context there, but for now I updated the apis in order to stick with what's expected by the compliance tool.
  • Delegates Created a separate ticket for this one. Might be worth waiting for picup migration to tackle this one

Already fixed

@flea89 flea89 marked this pull request as ready for review November 4, 2022 16:24
@flea89 flea89 mentioned this pull request Nov 7, 2022
Open
adamalton
adamalton approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@adamalton adamalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flea89 flea89 merged commit 8b1c1d3 into main Nov 30, 2022
@flea89 flea89 deleted the psa-api-compliance branch November 30, 2022 11:51
@github-actions github-actions bot mentioned this pull request Nov 30, 2022
Merged
adamalton pushed a commit that referenced this pull request Dec 13, 2022
@github-actions
chore(main): release api 7.13.0 (#2137)
c076720 
🤖 I have created a release *beep* *boop*
---


##
[7.13.0](api-v7.12.0...api-v7.13.0)
(2022-11-30)


### Features

* list and ability to delete psa request created though deleted tokens
([#2054](#2054))
([e150d1f](e150d1f))


### Bug Fixes

* allow update PSA pin requests with same CID
([#2125](#2125))
([0013efd](0013efd)),
closes [#1547](#1547)
* PSA compliance fixes
([#2091](#2091))
([8b1c1d3](8b1c1d3)),
closes [#1579](#1579)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshJarr joshJarr joshJarr approved these changes

@adamalton adamalton adamalton approved these changes

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinning Service Compliance Checker failures
4 participants
@flea89 @alanshaw @adamalton @joshJarr